Add feedback message parameter to banner component#620
Closed
Add feedback message parameter to banner component#620
Conversation
| {{/if}} | ||
| {{#if @subtitle}} | ||
| <span class="text-size-4 font-color-gray-500">{{@subtitle}}</span> | ||
| <div class="fx-col fx-gap-px-6"> |
Contributor
There was a problem hiding this comment.
Do you check in upfluence-web that doesn't break anything?
Member
There was a problem hiding this comment.
+1000
I'm fairly certain that this will break at least somewhere 😬
Contributor
Author
There was a problem hiding this comment.
I had to search hard to find a place where it breaks, but it breaks 🥲
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
Miexil
reviewed
Jan 19, 2026
| plain?: boolean; | ||
| selected?: boolean; | ||
| disabled?: boolean; | ||
| feedbackMessage?: FeedbackMessage; |
Member
There was a problem hiding this comment.
@phndiaye & @JulienVannier66 wdyt about adding the hasError: boolean counterpart here ?
It basically shows the red border when truthy
Contributor
There was a problem hiding this comment.
Yes, go add this only for the red border. But can we found a more general solution for other feedback border?
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a red border and error message to OSS::Banner component when
@feedbackMessageargument is passedRelated to: #7099
What are the observable changes?
Good PR checklist